Add Debian #2
Add Debian #2
Conversation
|
Thanks. The build is failing though, could you add the necessary staging module to the Modulefile, squash the commits into one, and run puppet-lint? |
Break out functionality into smaller manifests Minor changes after running puppet-lint
|
Hi Carlos, Please find the updated PR. Note that I converted the Modulefile into a metadata.json file as this is the newer format, and I was getting deprecation warnings. Thanks! |
|
I have pulled it into the debian branch with fixes to run the tests again, but the patch is still failing, see https://travis-ci.org/maestrodev/puppet-artifactory/builds/33145919 |
|
Hmm, it's saying "Cannot assign to variables in other namespaces", but one of the warnings I got with puppet-lint was about top-level namespaced variables, so I added the "artifactory::" scope. Do you know what might be causing this? :( |
| if $::osfamily == 'Debian' { | ||
|
|
||
| $url = "http://dl.bintray.com/jfrog/artifactory/artifactory-${artifactory::app_version}.zip" | ||
| $artifactory::extracted = "${artifactory::app_dir}/artifactory-${artifactory::app_version}" |
There was a problem hiding this comment.
you can't assign to a variable in other scope, just do $extracted
Add support for Debian / Ubuntu (tested on Ubuntu 14.04 and Centos 6.5).
Artifactory provides an RPM which can be used on Redhat based distros like Centos, but Debian users just get a zip file. This Puppet module will still continue to use the RPM to install on Centos, however this Pull Request adds support for Debian too. In the case of Debian, the zip file for the specified version (defaulting to 3.3.0) will be downloaded and extracted, a user for Artifactory created and an init script placed into /etc/init.d. This will be configured to execute at startup. I think this gives equivalent functionality to what the RPM does.