Remove c_void encoding hack
#535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
madsmtm
commented
Dec 3, 2023
Comment on lines
-7
to
-26
| error[E0283]: type annotations needed | ||
| --> ui/msg_send_underspecified_error.rs | ||
| | | ||
| | let _: Result<(), _> = unsafe { msg_send![obj, a: _] }; | ||
| | ^^^^^^^^^^^^^^^^^^^^ cannot infer type for raw pointer `*mut _` | ||
| | | ||
| = note: multiple `impl`s satisfying `*mut _: RefEncode` found in the `objc2` crate: | ||
| - impl RefEncode for *mut c_void; | ||
| - impl<T> RefEncode for *mut T | ||
| where T: RefEncode, T: ?Sized; | ||
| = note: required for `*mut *mut _` to implement `Encode` | ||
| note: required by a bound in `send_message_error` | ||
| --> $WORKSPACE/crates/objc2/src/__macro_helpers/msg_send.rs | ||
| | | ||
| | unsafe fn send_message_error<A, E>(self, sel: Sel, args: A) -> Result<(), Id<E>> | ||
| | ------------------ required by a bound in this associated function | ||
| | where | ||
| | *mut *mut E: Encode, | ||
| | ^^^^^^ required by this bound in `MsgSend::send_message_error` | ||
| = note: this error originates in the macro `$crate::__msg_send_helper` which comes from the expansion of the macro `msg_send` (in Nightly builds, run with -Z macro-backtrace for more info) |
There was a problem hiding this comment.
It may seem unfortunate that we're now missing this information, but in reality it's not actually helpful for the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was in theory useful back when references to
c_voidwere of higher likelihood, but nowadays I doubt it'll ever be an issue.Fixes #511.