Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ bump homeassistant form 2023.8.0 to 2024.3.3 #12

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

madmatah
Copy link
Owner

Purpose

We want to support the latest homeassistant version.
Also, the coordinator is not compatible with homeassistant 2023.8 😬

Proposal

  • upgrade homeassistant from 2023.8.0 to 2024.3.3
  • fix warning about invalid suggested_unit_of_measurment

Some walkingpad sensors are generating warnings in the logs:

>  <class 'custom_components.king_smith.sensor.WalkingPadSensor'> sets
>  an invalid suggested_unit_of_measurement. Please create a bug
>  report at https://github.com/madmatah/hass-walkingpad/issues. This
>  warning will become an error in Home Assistant Core 2024.5

Since the specified suggested_unit_of_measurements specified in the
sensors definition do not differ from their
native_unit_of_measurements, I don't think that they are very useful.
So I removed them.
@madmatah madmatah force-pushed the feature/bump-homeassistant-2024-3-3 branch from 66c06ef to 8ed13a8 Compare March 29, 2024 23:27
@madmatah madmatah merged commit ac76e81 into main Mar 29, 2024
3 checks passed
@madmatah madmatah deleted the feature/bump-homeassistant-2024-3-3 branch March 29, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant