add flake-compat and a default overlay for consumption in non-flake projects #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake.nix
Outdated
| // | ||
| { | ||
| overlays.default = (final: prev: { | ||
| yarnBerry = final.callPackage ./yarn.nix {}; |
There was a problem hiding this comment.
@madjam002 maybe we could rename it to yarn-berry_4? I'd like to keep it consistent with how it's used in the other parts of this repo.
and address issues highlighted by shellcheck (ran automatically by writeShellApplication) Note: this could be further improved by creating a derivation which which simply depends on the outputs out test and executes the built binaries within a sandbox. We could then have this derivation set as flakce check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also:
EDIT: also see this commit, which fixes
shell.nix, as currently it doesn't work with classicnix-shellnote that the actual devShell is defined in previous commit on that branch, and uses yarnBerry instead of yarn, as suggested in my other PR. Please let me know if you'd be willing to accept all of these changes in a single PR. Thanks!