Skip to content

Commit

Permalink
[stable/gce-ingress] allow key in secret to be overridden (helm#14347)
Browse files Browse the repository at this point in the history
Allow user to override the key for your google.json cred in your secret

Signed-off-by: Paul Czarkowski <[email protected]>
  • Loading branch information
paulczar authored and k8s-ci-robot committed Jun 1, 2019
1 parent c90d037 commit fe5e83f
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion stable/gce-ingress/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
appVersion: "1.4.0"
description: A GCE Ingress Controller
name: gce-ingress
version: 1.1.2
version: 1.2.0
keywords:
- ingress
- gce
Expand Down
2 changes: 2 additions & 0 deletions stable/gce-ingress/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ Parameter | Description | Default
`defaultBackend.replicaCount` | desired number of default backend pods | `1`
`defaultBackend.resources` | default backend pod resource requests & limits | `{}`
`rbac.enabled` | use RBAC ? | `true`
`secret` | the name of the secret containing your google creds json | ``
`secretKey` | override the key containing your google creds json | ``

```console
$ helm install stable/gce-ingress --name my-release
Expand Down
2 changes: 1 addition & 1 deletion stable/gce-ingress/templates/deployment-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ spec:
secret:
secretName: {{ .Values.secret }}
items:
- key: key.json
- key: {{ default "key.json" .Values.secretKey }}
path: key.json
{{- end }}
- name: gce-config-volume
Expand Down
7 changes: 0 additions & 7 deletions stable/gce-ingress/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,3 @@ spec:
component: backend
release: {{ .Release.Name }}

name: default-http-backend
namespace: kube-system
labels:
k8s-app: glbc
kubernetes.io/cluster-service: "true"
addonmanager.kubernetes.io/mode: Reconcile
kubernetes.io/name: "GLBCDefaultBackend"
3 changes: 3 additions & 0 deletions stable/gce-ingress/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ serviceAccount:
# key.json: < base64 encoded JSON service account key>
secret: ~

## If the google auth file is saved in a different secret key you can specify it here
# secretKey: key.json

# gce config, replace values to match your environment
config:
projectID:
Expand Down

0 comments on commit fe5e83f

Please sign in to comment.