Fix CMake build on Apple Silicon #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake_host_system_information returns false currently
|
The mpg123-devel mailing list has been notified of the existence of this pr. |
|
Applied to svn, thanks. I don't consider this something urgent, though, as you can build mpg123 on Mac just fine using autotools (right?). Maybe we should have a CI target for that, too. |
Yeah, autotools builds fine. |
|
So … finished here? |
|
Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple silicon,
cmake_host_system_information(RESULT HAVE_FPU QUERY HAS_FPU)returnsHAVE_FPU=0.I reported this upstream.
Without a detected fpu, the build fails when
REAL_IS_FIXEDis defined, and neon is detected.https://github.com/madebr/mpg123/actions/runs/8916112597/job/24486953667#step:5:13
My fix moves the cpu arch detection earlier, and hard enables
HAVE_FPUfor apple arm64.As an extra, I added a patch that adds macos CI.