fix: recreate a monitor when a query is updated

mackerelio-labs · May 15, 2024 · 77657c5 · 77657c5
1 parent 9b1b187
commit 77657c5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/mackerel/resource_mackerel_monitor.go b/mackerel/resource_mackerel_monitor.go
@@ -341,6 +341,7 @@ func resourceMackerelMonitor() *schema.Resource {
 						"query": {
 							Type:     schema.TypeString,
 							Required: true,
+							ForceNew: true,
 						},
 						"legend": {
 							Type:     schema.TypeString,

diff --git a/mackerel/resource_mackerel_monitor_test.go b/mackerel/resource_mackerel_monitor_test.go
@@ -514,7 +514,7 @@ func TestAccMackerelMonitor_Query(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "anomaly_detection.#", "0"),
 					resource.TestCheckResourceAttr(resourceName, "query.#", "1"),
 					resource.ComposeTestCheckFunc(
-						resource.TestCheckResourceAttr(resourceName, "query.0.query", "container.cpu.utilization{k8s.deployment.name=\"httpbin\"}"),
+						resource.TestCheckResourceAttr(resourceName, "query.0.query", "container.cpu.utilization{k8s.deployment.name=\"nginx\"}"),
 						resource.TestCheckResourceAttr(resourceName, "query.0.legend", "cpu.utilization {{k8s.node.name}}"),
 						resource.TestCheckResourceAttr(resourceName, "query.0.operator", ">"),
 						resource.TestCheckResourceAttr(resourceName, "query.0.warning", "70"),
@@ -860,7 +860,7 @@ resource "mackerel_monitor" "foo" {
   is_mute = true
   notification_interval = 30
   query {
-    query = "container.cpu.utilization{k8s.deployment.name=\"httpbin\"}"
+    query = "container.cpu.utilization{k8s.deployment.name=\"nginx\"}"
     legend = "cpu.utilization {{k8s.node.name}}"
     operator = ">"
     warning = "70"