Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the codes for unlisted languages to languages list #546

Merged
merged 10 commits into from
Oct 24, 2023

Conversation

tovmasharrison
Copy link
Contributor

Description

In the Languages article, I have just listed codes for the languages for which we don't have an entry.

Fixes #486

Checklist:

@cefoo
Copy link
Collaborator

cefoo commented Oct 11, 2023

Hi @tovmasharrison!

Thank you for your PR!
I have tested it locally and it is fully functional! Thanks!

This is a personal impression, but I feel like, for languages we just have codes, perhaps it would be neater to not display the code twice.

When this PR is merged, we would see the language list (this is taken from niutrans.md).
Screenshot 2023-10-11 at 09 38 31

As Adam mentioned in #486, it would be great to automatically get the languages names for those codes. However, I'm not sure how necessary it is, since as soon as we create language pages for each of these codes, then we won't need that solution anymore… Unless an API starts supporting languages that aren't already supported by Machine Translate. (For another issue).

@cefoo cefoo requested a review from bittlingmayer October 11, 2023 12:51
@tovmasharrison
Copy link
Contributor Author

Hi @cefoo!

No problem!

Just let me know if only the language code needs to be displayed.

@bittlingmayer
Copy link
Collaborator

Re crp @cefoo that code is just for Creoles in general - so that's some Lilt-specific code, which we need to add to https://github.com/machinetranslate/machinetranslate.org/blob/master/_data/api_language.json to redirect to its proper code.

@bittlingmayer
Copy link
Collaborator

We don't actually need to put this in the .md files:
Screenshot 2023-10-21 at 23 49 18

In generate.py, we could delete supported_language_count after we use it to sort.

@bittlingmayer
Copy link
Collaborator

We need to update languages.html template, so that if we have a code but no name:

  • We should put it in backticks, at least in the article text, and ideally also in the title and description.
  • We should add a note:

This language has not yet been fully added to Machine Translate.

You can add it to Machine Translate by getting the name, language family, script and typology to languages.json and submitting a pull request.

You may be able to find this information in its Wikipedia article.

@cefoo
Copy link
Collaborator

cefoo commented Oct 23, 2023

Re crp @cefoo that code is just for Creoles in general - so that's some Lilt-specific code, which we need to add to https://github.com/machinetranslate/machinetranslate.org/blob/master/_data/api_language.json to redirect to its proper code.

In their documentation, Lilt just mentions "Creole" as a supported language:
Screenshot 2023-10-23 at 09 49 58

What can we do in that case?

@bittlingmayer
Copy link
Collaborator

In their documentation, Lilt just mentions "Creole" as a supported language:
What can we do in that case?

I looked through their docs, but they don't list it anywhere.

Write to their support? (Or sales - they'll answer faster. ;-))

My guess would be Haitian Creole, but it could be some other French-, English-, Spanish- or Portuguese-based Creole.

@bittlingmayer
Copy link
Collaborator

I added a bug here: #553

Copy link
Collaborator

@bittlingmayer bittlingmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge once conflicts are resolved.

I created a bug about Lilt's "Creole": #553

@tovmasharrison
Copy link
Contributor Author

Conflicts are resolved. (cc) @bittlingmayer

@bittlingmayer bittlingmayer merged commit 8fcd474 into machinetranslate:master Oct 24, 2023
@cefoo
Copy link
Collaborator

cefoo commented Oct 24, 2023

In their documentation, Lilt just mentions "Creole" as a supported language:
What can we do in that case?

I looked through their docs, but they don't list it anywhere.

Write to their support? (Or sales - they'll answer faster. ;-))

My guess would be Haitian Creole, but it could be some other French-, English-, Spanish- or Portuguese-based Creole.

I'll ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Languages article should list languages for which we only have a code.
3 participants