-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the codes for unlisted languages to languages list #546
Add the codes for unlisted languages to languages list #546
Conversation
Hi @tovmasharrison! Thank you for your PR! This is a personal impression, but I feel like, for languages we just have codes, perhaps it would be neater to not display the code twice. When this PR is merged, we would see the language list (this is taken from As Adam mentioned in #486, it would be great to automatically get the languages names for those codes. However, I'm not sure how necessary it is, since as soon as we create language pages for each of these codes, then we won't need that solution anymore… Unless an API starts supporting languages that aren't already supported by Machine Translate. (For another issue). |
Hi @cefoo! No problem! Just let me know if only the language code needs to be displayed. |
Re |
We need to update languages.html template, so that if we have a code but no name:
|
In their documentation, Lilt just mentions "Creole" as a supported language: What can we do in that case? |
I looked through their docs, but they don't list it anywhere. Write to their support? (Or sales - they'll answer faster. ;-)) My guess would be Haitian Creole, but it could be some other French-, English-, Spanish- or Portuguese-based Creole. |
I added a bug here: #553 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge once conflicts are resolved.
I created a bug about Lilt's "Creole": #553
Conflicts are resolved. (cc) @bittlingmayer |
I'll ask! |
Description
In the Languages article, I have just listed codes for the languages for which we don't have an entry.
Fixes #486
Checklist: