Freerb/tms #344
Draft
Freerb/tms #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the TempSensorManager class since all it did was run a loop over the temp sensors. This loop is now in main. Moves the temperature sensor calculations to a separate header file. Simplifies the TemperatureSensor class.
Create the BmsBroadcast message in a standalone function so that we don't need to maintain another class. Moves the avg / low / high temperature calculations into this Pack() method to cut down the number of arguments.
The step size in FanController is now determined by the task rate. FreeRTOS has been disabled. There was only a single task so an RTOS was unnecessary complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move TMS to the new CAN system. I wanted to simplify the app objects and overall system to reduce the amount of abstractions which we make. Did this by removing the TempSensorManager and BmsBroadcaster objects and inlining their behaviour.
The other big change is I removed FreeRTOS and now use a baremetal loop. TMS is a very simple project - it runs a single deterministic task every 100ms. There is no synchronization or scheduling, so an RTOS is not a good fit. Further, removing the RTOS means we can debug in the CLI, so I added that platform folder as well
Expand the commit messages
...below for more details.