Freerb/242 update can drivers (#322) #339
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds missing import * moves and removes unused files * Reimplement CAN * Adds message formatter * bk work * for review * simplify get and pop methods * remove unused import * Add comments to Pop and Get * Update headers * Rename veh to demo * Update scripts/cangen/cangen/templates/bus.h.jinja2 Co-authored-by: Samuel Parent <[email protected]> * Add clang-format on * Explain optional unpacking * Revert to TxMessage concept --------- Co-authored-by: Samuel Parent <[email protected]>
* Add extended frame support to CanMessage * stm32 can driver, remove mutex on bus for now * Merge to hpp * Convert shared and stm mcal CMake libaries to Interface so they link properly * Move Linux to Interface library, fix headers & CMake bindings * atomic buffer * Update Nucleo Docs for Demo/CAN and CANGEn docs * remove unused imports * Remove unused imports * Abstract out AtomicBuffer and use in CAN bus. * Rename Register function * Add forware declare comment * Inclusion guard * feat: Move `pack` and `unpack`. Moved out of templates / generated code into `shared/comms/can/msg.hpp`. Prevents redefinition if multiple `_messages.hpp` files exist (eg. Veh and Pt CAN) * fix: Fix GetTimestamp calculation. We should not multiply by `HAL_GetTickFreq()`. The `HAL_GetTick()` method "Provides a tick value in millisecond." according to the HAL guide UM 1905. Also, multiplying by freq would give the wrong units since its 1/second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing import
moves and removes unused files
Reimplement CAN
Adds message formatter
bk work
for review
simplify get and pop methods
remove unused import
Add comments to Pop and Get
Update headers
Rename veh to demo
Update scripts/cangen/cangen/templates/bus.h.jinja2
Add clang-format on
Explain optional unpacking
Revert to TxMessage concept