-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
201 can errors cli viewer #316
Conversation
… menu is opened.~ ~11. Make border purple for the description.~ ~12. Move the help menu to the top.~ ~13. Make all the displays the same size.~
… make code more legible.
…the error table is opened, and added a testing script
The table rendering and program loop code looks good. There's a few Demo files that shouldn't be included in the merge. Use git rm to delete them. I noticed that information about the error messages (like freshness) is stored in the table itself. This isn't the best design. The table should only be used as an output to represent the internal state of the system. You should have an array / list or similar holding a struct for each message type that includes all relevant fields, then sort that array by freshness and display those structs in the table rows. This will remove functions like re_fresh, SortByColumn, and FindRowString which operate on the table data. After this fix is made, you should (almost) never need to call string.Atoi on any table values - this data should be stored as an integer somewhere else. |
…oved box/table under components, removed demos.
…error imdex, more readme information, no more searching with string, no more "reading from the table (?), and other cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good improvements. Few things to improve but overall looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments should be removed since they don't add any information which isn't already clear from the function title. I marked some examples of good comments and ones which can be removed
…ore descriptive, updated README
No description provided.