Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #201] CAN errors C++ implementation #314

Merged
merged 15 commits into from
Nov 20, 2024

Conversation

luaibash
Copy link
Contributor

@luaibash luaibash commented Nov 10, 2024

Description

  • Systems within the vehicle must communicate on if an error has occurred. We need an interface for errors such that we can access and throw a specific error when it has occurred, and have it be sent through CAN for other systems to determine if an error has occurred.
  • Created new project CANErrors to hold this implementation.
  • Added a dbc file that generates a 64 bit error integer, where each bit will be treated as a separate error, 64 total errors.
  • Created new class ErrorHandler to hold this error object, and define methods to set different errors, and send them.
  • Defined an enum that holds all 64 errors.

@luaibash luaibash linked an issue Nov 10, 2024 that may be closed by this pull request
firmware/projects/Demo/CANErrors/README.md Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/errors.dbc Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
@BlakeFreer
Copy link
Contributor

In general, functions, variables, constants etc should be named following this guide

https://google.github.io/styleguide/cppguide.html#Naming

firmware/projects/Demo/CANErrors/README.md Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/README.md Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/errors.dbc Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
firmware/projects/Demo/CANErrors/inc/app.h Outdated Show resolved Hide resolved
@BlakeFreer BlakeFreer merged commit be96e0e into main Nov 20, 2024
1 check passed
@BlakeFreer BlakeFreer deleted the 201-can-errors-c-implementation branch November 20, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAN Errors
2 participants