Brake Pedal Position and Brake Pedal Light Logic #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabrap1
requested review from
samparent97,
BlakeFreer and
TylerStAmour
as code owners
BlakeFreer
requested changes
Nov 3, 2024
BlakeFreer
requested changes
Nov 3, 2024
…ts into two functions
BlakeFreer
requested changes
Nov 4, 2024
BlakeFreer
requested changes
Nov 4, 2024
BlakeFreer
added a commit
that referenced
this pull request
Jan 6, 2025
* create add function (#245) * ctrls (#258) * adds asserts for booleans (#260) * Changed template to match 'controls' template, added template to functions to account for unknown variables, cleaned up error handling function (#259) * driver_interface_error_handling * driver_interface_error * driver_interface_error_handling cleanup and test cases * Delete controls_rewrite_folder/driver_interface_error_handling.cpp * Added some test cases, removed edge cases, got rid of tolerance * changed test casing, got rid of controls rewrite folder, moved to firmware/shared/controls * Delete controls_rewrite_folder directory * fmt * fmt * revision * revision * revision * Delete firmware/shared/controls/driver_interface_error_handling_test.cpp Deleting cpp file * controls: Torque Request (#272) * Finished my drivercontrols (blue) function + test case file, but having trouble compling with the MakeFile. * formatting * Fixed the template, the function behavior, Makefile issues, and the test file. * Fixed naming conventions, renamed files, and added possible boolean combinations with all tests passed. * Changed the test conditions + added detailed explanations --------- Co-authored-by: BlakeFreer <[email protected]> * Brake Pedal Position and Brake Pedal Light Logic (#288) * wrote brake_pedal_light * Implemented recommended edits to functions and split brake_pedal_lights into two functions * Changed line 14, the return statement, as requested * removed unneeded import * Steering Angle Logic (#290) * created steering angle function * fixed typo, removed unneeded import, and removed comment * Controls: TC Scale Factor (#292) * Controls: TC Scale Factor * Removed the redundant function and made the stateflow placeholder the CalculateTCScaleFactor function. Also fixed the bounding if-statement in actual slip function. * Shene7/feature (#287) * Raw Work * added open_loop_tv algorithm, lookup table handling, etc * created look up table datatypes, made tv factoring a tuple data type * before formatting * test * formatted test cases * Test Case Rewrite3 * made variable name and formatting changes, see replies to comments in pr * applied comments, changed EnableTorqueVectoring to bool * got rid of bool function, changed var naems * got rid of boolean checks * Motor Torque logic and testing (#302) * Motor Torque logic and testing, need feedback on how to incorporate finite state machine into final code * scale was off by a factor of 100 * fixed issues regarding using shared library, while loop, and static variables. Unsure if the reset method implemented currently is the most efficent way of reseting between tests * Update include paths * added a reset flag to the CalculateMotorTorque function and rid of classes * Removed default case, moved enums into ctrl namespace, and added extra testcases * removed scale factor --------- Co-authored-by: BlakeFreer <[email protected]> --------- Co-authored-by: shene7 <[email protected]> Co-authored-by: OJ Esene <[email protected]> Co-authored-by: Peter Jabra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.