feat: Use the CubeMX Java runtime environment #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on windows. Removes the need for a separate dependency and the version is guaranteed to match. Unsure if Java is packages with cubemx on Mac / Linux. See #142
BlakeFreer
added
documentation
|
I did not update the firmware/README to show this change. The docs will be updated in #28 |
|
Lgtm, haven't tested though |
TylerStAmour
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JRE is installed with CubeMX on windows. Using this version removes the need for a separate dependency and guarantees that the JRE version matches Cube.
Edits firmware/cmake/generate_cubemx.mk to use this executable on Windows
I am unsure if Java is packages with cubemx on Mac / Linux so this PR still uses a separate Java installation. See #142