refactor(can-gen): ♻️ Improve CAN generation and build support. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert ETL from an include path to a proper target in CMake. Refactor cangen Python code to use a functional paradigm and be more "Pythonic"
BlakeFreer
requested review from
samparent97,
tullom and
clarawong20
as code owners
BlakeFreer
force-pushed
the
user/freerb/can-cleanup
branch
from
ee8bfca to
a5361ec
Compare
…rgparse-addons==0.12.0 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 1)) (0.12.0) Requirement already satisfied: bitstruct==8.19.0 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 2)) (8.19.0) Requirement already satisfied: cantools==39.4.5 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 3)) (39.4.5) Requirement already satisfied: crccheck==1.3.0 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 4)) (1.3.0) Requirement already satisfied: diskcache==5.6.3 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 5)) (5.6.3) Requirement already satisfied: Jinja2==3.1.3 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 6)) (3.1.3) Requirement already satisfied: MarkupSafe==2.1.5 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 7)) (2.1.5) Requirement already satisfied: numpy==1.26.4 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 8)) (1.26.4) Requirement already satisfied: packaging==24.0 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 9)) (24.0) Requirement already satisfied: python-can==4.3.1 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 10)) (4.3.1) Requirement already satisfied: pywin32==306 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 11)) (306) Requirement already satisfied: PyYAML==6.0.1 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 12)) (6.0.1) Requirement already satisfied: textparser==0.24.0 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 13)) (0.24.0) Requirement already satisfied: typing_extensions==4.11.0 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 14)) (4.11.0) Requirement already satisfied: wrapt==1.16.0 in c:\formula\repos\.env\lib\site-packages (from -r requirements.txt (line 15)) (1.16.0) to install all
samparent97
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert ETL from an include path to a proper target in CMake. Refactor cangen Python code to use a functional paradigm and be more "Pythonic"
Closes #104
Closes #105
Python Validation: for democan, the new script generates files that are character-for-character equal to the old script.