Request for comments #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Arena Entity as it will be a service not an Entity as per specifications Migrated schema changes
Minor correction in KnightControllerTest (fipped arguments for signature consistency)
…f annotations. Since SF4.4 is now mature upgrading from 4.3 to 4.4 should not be a pb
Changed the class name and asjusted some types for class Human (now AbstractHuman) : class name shouldmatch filename Added basic "CRUD" for Knights entity (add / fetch / fetchAll) Added control on requests content type and datas
Added symfony serializer to handle easily json content Had to change the wy we retrieve the request. In test env, the kernel is not booted the same , we don't get the headers in __construct => injecting Response in methods solves the problem Adjusted controller and entities to match tests output expectations Modified a test to match the Knights controller output for fetchAll (I prefer to keep the data node in the output structure) Status : all Knights tests are passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thank you for this challenge
I didn't code for a long time and wanted to get back at it , more especially by diving into symfony
It really helped me to go from theory to a bit more practical with Symfony
I'd love to have some feedback if you got some time ...
Best regards
Nassim