Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Swift File Support #211

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: Fix Swift File Support #211

merged 1 commit into from
Nov 8, 2024

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

Fix swift files not available in React SDK

Testing Plan

Tested to confirm consent states made it to sdk

Master Issue

Closes https://go.mparticle.com/work/SQDSDKS-6905

@BrandonStalnaker BrandonStalnaker self-assigned this Nov 5, 2024
@BrandonStalnaker
Copy link
Contributor Author

BrandonStalnaker commented Nov 5, 2024 •
edited
Loading

@einsteinx2 I'm between this fix and a change to the core SDK to add #import "MParticleSwift.h" to the mParticle.h file though that doesn't seem to work how I'd expect. I'd prefer the latter but this is what works.

einsteinx2
einsteinx2 approved these changes Nov 8, 2024
View reviewed changes
Copy link

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed on Zoom

@BrandonStalnaker BrandonStalnaker merged commit 9454b03 into main Nov 8, 2024
10 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/6905-Fix-Swift-File-Support branch November 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrandonStalnaker @einsteinx2