fix: 6078 update imports #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einsteinx2
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Readme update and header changes look good. Podspec seems ok but I'm getting npm errors when doing a pod lint which will need to succeed to release this.
Ideally let's add another step to the pull requests actions to do a pod lint for iOS.
Also we need to update all checkout@v3 actions to v4 for github runner reasons.
BrandonStalnaker
force-pushed
the
fix/6078-Update-Imports
branch
from
a58c30a to
55d9e64
Compare
BrandonStalnaker
force-pushed
the
fix/6078-Update-Imports
branch
from
6f41108 to
76cced9
Compare
BrandonStalnaker
force-pushed
the
fix/6078-Update-Imports
branch
from
76cced9 to
b5ac0ff
Compare
rmi22186
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users seem to be having trouble figuring out the correct imports and/or React keeps changing the system and causing them to need to change there tactics. This change ensures we are using a more durable way of importing mParticle.
Additionally, with recent architecture changes from React Native further configuration needs done at the framework level depending on what version of the architecture is being used. This change updates the react-native-mparticle.podspec to consume the
install_modules_dependenciesfunction provided by React Native to configure the pods dependencies. Similar to whats being done on React's frameworks.Testing Plan
Tested by making a react app from scratch and confirming it ran and could send data to mParticle. Can't fully confirm until cocaopods is updated.
Master Issue
Closes https://go.mparticle.com/work/SQDSDKS-6078