Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include consent query parameters for cookie sync #966

Open
wants to merge 5 commits into
base: refactor/ts-migration-blackout-2024
Choose a base branch
from

Conversation

rmi22186
Copy link
Member

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • If a consent string is not appended to GMP Cookie Syncs, Google will exclude these users from audiences. TCF (Transparency and Consent Framework) has specific implementation instructions that all cookie sync customers follow in order to include if someone has or has not consented
  • All Consent Management Platforms (such as OneTrust), are required to implement a function on window.__tcfapi to return TCF strings which contains what a user has/has not consented. This gets appended to the end of a cookie sync.
  • We call the API using getInAppTCData, which then returns a tcData object, and we only need the keys gdprApplies and tcString

Testing Plan

  • Was this tested locally? If not, explain why.
    Added unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle force-pushed the refactor/ts-migration-blackout-2024 branch from b28c45d to 29f34b0 Compare January 21, 2025 15:04
@rmi22186 rmi22186 force-pushed the feat/SQDSDKS-6991-cookie-sync-gdpr-2 branch from 2c977b9 to 9246789 Compare January 21, 2025 15:44
@alexs-mparticle alexs-mparticle force-pushed the refactor/ts-migration-blackout-2024 branch from 29f34b0 to 78a0cb2 Compare January 21, 2025 17:13
@rmi22186 rmi22186 force-pushed the feat/SQDSDKS-6991-cookie-sync-gdpr-2 branch from 9246789 to 85f1887 Compare January 21, 2025 21:08
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
src/cookieSyncManager.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants