-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include consent query parameters for cookie sync #966
Open
rmi22186
wants to merge
5
commits into
refactor/ts-migration-blackout-2024
Choose a base branch
from
feat/SQDSDKS-6991-cookie-sync-gdpr-2
base: refactor/ts-migration-blackout-2024
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Include consent query parameters for cookie sync #966
rmi22186
wants to merge
5
commits into
refactor/ts-migration-blackout-2024
from
feat/SQDSDKS-6991-cookie-sync-gdpr-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
force-pushed
the
refactor/ts-migration-blackout-2024
branch
from
January 21, 2025 15:04
b28c45d
to
29f34b0
Compare
rmi22186
force-pushed
the
feat/SQDSDKS-6991-cookie-sync-gdpr-2
branch
from
January 21, 2025 15:44
2c977b9
to
9246789
Compare
alexs-mparticle
force-pushed
the
refactor/ts-migration-blackout-2024
branch
from
January 21, 2025 17:13
29f34b0
to
78a0cb2
Compare
rmi22186
force-pushed
the
feat/SQDSDKS-6991-cookie-sync-gdpr-2
branch
from
January 21, 2025 21:08
9246789
to
85f1887
Compare
alexs-mparticle
requested changes
Jan 22, 2025
rmi22186
commented
Jan 23, 2025
rmi22186
commented
Jan 23, 2025
alexs-mparticle
requested changes
Jan 24, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
development
Summary
window.__tcfapi
to return TCF strings which contains what a user has/has not consented. This gets appended to the end of a cookie sync.tcData
object, and we only need the keysgdprApplies
andtcString
Testing Plan
Added unit tests
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)