refactor: Add Type interfaces for identity api client #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
force-pushed
the
refactor/SQDSDKS-6678-identity-api-client-interfaces
branch
from
1568db5 to
c16c104
Compare
rmi22186
reviewed
Nov 8, 2024
rmi22186
reviewed
Nov 8, 2024
rmi22186
requested changes
Nov 8, 2024
There was a problem hiding this comment.
generally lgtm, but see my comment about PR-ing into a feature branch so that the unused interface is appropriately used and shown to be working. not a hill i'd die on (especially for less complicated interfaces such as https://github.com/mParticle/mparticle-web-sdk/pull/946/files), and i'm open to just merging it straight in. but figured good to discuss.
|
rmi22186
approved these changes
Nov 8, 2024
rmi22186
pushed a commit
that referenced
this pull request
Dec 18, 2024
alexs-mparticle
added a commit
that referenced
this pull request
Jan 17, 2025
alexs-mparticle
added a commit
that referenced
this pull request
Jan 21, 2025
alexs-mparticle
added a commit
that referenced
this pull request
Jan 21, 2025
alexs-mparticle
added a commit
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)