Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update broken links in comments #787

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

rmi22186
Copy link
Member

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

/developers/sdk/javascript was changed to /developers/sdk/web and this link update was missed in this file.

Note that http://docs.mparticle.com/developers/sdk/javascript/event-tracking#event-type does not work, but https://docs.mparticle.com/developers/sdk/web/event-tracking/#event-type does.

Testing Plan

  • Was this tested locally? If not, explain why.
    Tested link

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 requested a review from einsteinx2 October 12, 2023 14:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rmi22186 rmi22186 merged commit 223c4ed into development Oct 12, 2023
27 checks passed
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 2.23.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rmi22186 rmi22186 deleted the docs/SQDSDKS-5865-update-links branch November 17, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants