WIP

mParticle · Jan 6, 2025 · 7681164 · 7681164
1 parent c66ec58
commit 7681164
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 20 deletions.
diff --git a/src/cookieSyncManager.ts b/src/cookieSyncManager.ts
@@ -110,22 +110,15 @@ export default function CookieSyncManager(
                 redirectUrl
             );
 
+            // reset shouldPerformCookieSync to false
+            let shouldPerformCookieSync = false;
             if (previousMPID && previousMPID !== mpid) {
                 if (persistence && persistence[mpid]) {
                     if (!persistence[mpid].csd) {
                         persistence[mpid].csd = {};
                     }
-                    self.performCookieSync(
-                        urlWithRedirect,
-                        moduleId,
-                        mpid,
-                        persistence[mpid].csd,
-                        filteringConsentRuleValues,
-                        mpidIsNotInCookies,
-                        requiresConsent
-                    );
+                    shouldPerformCookieSync = true;
                 }
-                return;
             } else {
                 if (!persistence || !persistence[mpid]) {
                     return;
@@ -139,17 +132,22 @@ export default function CookieSyncManager(
 
                 // Check to see if we need to refresh cookieSync
                 if (hasFrequencyCapExpired(frequencyCap, lastSyncDateForModule)) {
-                    self.performCookieSync(
-                        urlWithRedirect,
-                        moduleId,
-                        mpid,
-                        persistence[mpid].csd,
-                        filteringConsentRuleValues,
-                        mpidIsNotInCookies,
-                        requiresConsent
-                    );
+                    shouldPerformCookieSync = true;
                 }
             }
+
+            if (shouldPerformCookieSync) {
+                self.performCookieSync(
+                    urlWithRedirect,
+                    moduleId,
+                    mpid,
+                    persistence[mpid].csd,
+                    filteringConsentRuleValues,
+                    mpidIsNotInCookies,
+                    requiresConsent
+                );
+            }
+
         });
     };
 

diff --git a/test/src/tests-cookie-syncing.ts b/test/src/tests-cookie-syncing.ts
@@ -31,7 +31,7 @@ declare global {
 
 const mParticle = window.mParticle;
 
-describe('cookie syncing', function() {
+describe.only('cookie syncing', function() {
     const timeout = 100;
     // Have a reference to createElement function to reset after all cookie sync
     // tests have run