Save Point

mParticle · Nov 21, 2024 · 2209b69 · 2209b69
1 parent 3d87fe2
commit 2209b69
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/src/identity.js b/src/identity.js
@@ -1,5 +1,5 @@
 import Constants, { HTTP_OK } from './constants';
-import Types from './types';
+import Types, { IdentityType } from './types';
 import {
     cacheOrClearIdCache,
     createKnownIdentities,
@@ -17,7 +17,6 @@ import {
     isObject,
 } from './utils';
 import { hasMPIDAndUserLoginChanged, hasMPIDChanged } from './user-utils';
-import { IdentityType } from './types';
 import { processReadyQueue } from './pre-init-utils';
 
 export default function Identity(mpInstance) {

diff --git a/src/sdkRuntimeModels.ts b/src/sdkRuntimeModels.ts
@@ -8,7 +8,7 @@ import {
 } from '@mparticle/web-sdk';
 import { IStore } from './store';
 import Validators from './validators';
-import { Dictionary } from './utils';
+import { Dictionary, valueof } from './utils';
 import { IServerModel } from './serverModel';
 import { IKitConfigs } from './configAPIClient';
 import { SDKConsentApi, SDKConsentState } from './consent';
@@ -154,7 +154,7 @@ interface IEvents {
 export interface MParticleWebSDK {
     addForwarder(mockForwarder: MPForwarder): void;
     _IntegrationCapture: IntegrationCapture;
-    IdentityType: typeof IdentityType;
+    IdentityType: valueof<typeof IdentityType>;
     _Identity: IIdentity;
     Identity: SDKIdentityApi;
     Logger: SDKLoggerApi;

diff --git a/src/types.ts b/src/types.ts
@@ -1,5 +1,5 @@
 import Constants from './constants';
-import { parseNumber } from './utils';
+import { parseNumber, valueof } from './utils';
 
 interface IdentitiesByType {
     [key: number]: string;
@@ -87,7 +87,7 @@ export const EventType = {
                 return 'Other';
         }
     },
-} as const;
+};
 
 // Continuation of EventType enum above, but in seperate object since we don't expose these to end user
 export const CommerceEventType = {
@@ -131,7 +131,7 @@ export const IdentityType = {
 
     isValid(identityType: number): boolean {
         if (typeof identityType === 'number') {
-            for (var prop in IdentityType) {
+            for (const prop in IdentityType) {
                 if (IdentityType.hasOwnProperty(prop)) {
                     if (IdentityType[prop] === identityType) {
                         return true;
@@ -166,7 +166,7 @@ export const IdentityType = {
         }
     },
 
-    getIdentityType: (identityName: string): typeof IdentityType | boolean => {
+    getIdentityType: (identityName: string): valueof<typeof IdentityType> | boolean => {
         switch (identityName) {
             case 'other':
                 return IdentityType.Other;
@@ -264,10 +264,10 @@ export const IdentityType = {
         }
     },
 
-    getNewIdentitiesByName: (newIdentitiesByType: IdentitiesByType) => {
+    getNewIdentitiesByName: (newIdentitiesByType: IdentitiesByType): IdentitiesByType => {
         const newIdentitiesByName: IdentitiesByType = {};
 
-        for (var key in newIdentitiesByType) {
+        for (const key in newIdentitiesByType) {
             const identityNameKey = IdentityType.getIdentityName(
                 parseNumber(key)
             );
@@ -384,7 +384,7 @@ export const ApplicationTransitionType = {
     AppInit: 1 as const,
 };
 
-export default{
+export default {
     MessageType,
     EventType,
     CommerceEventType,