chore: better select prop types to match antd exports #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Forge |
|
ajenkins-mparticle
approved these changes
Nov 5, 2024
…Particle/aquarium into chore/better-select-prop-types
## [1.34.1-chore-better-select-prop-types.2](v1.34.1-chore-better-select-prop-types.1...v1.34.1-chore-better-select-prop-types.2) (2024-11-05)
Oh definitely, thanks for pointing that out. I've been working on this since last week and totally forgot I had done that. |
tibuurcio
commented
Nov 8, 2024
Comment on lines
+24
to
+25
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-expect-error Introduced when we properly typed the Select value and option generics from Aquarium. Need to double check to fix this. |
There was a problem hiding this comment.
@jared-dickman @ZoeAstra would any of you guys be able to take a quick look at this? I didn't want to change anything without the proper context. Ideally the <Select> used here in Qualifier would be typed and hopefully this problem would be avoided 🙌🏼
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes Aquarium Select component match the way Antd exports its props so we are able to use generics while developing with the Select component.
It also fixes the
suffixIconto be thedropdownOpenicon from Aquarium.Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)