Satisfy code quality checks and generalize to non-pyqg use-cases #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asross
force-pushed
the
code-quality-plus-generalization
branch
from
68788ec
to
202b969
Compare
asross
force-pushed
the
code-quality-plus-generalization
branch
from
202b969
to
0d4daef
Compare
jdenholm
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements numerous code quality improvements (better variable names, type annotations, misc. refactors).
Also generalizes spatial symbolic regression so that it works on datasets not generated from pyqg, as long as they have
x,y,l, andkdimensions. Does not require thelevdimension but will use it if present. (Includes assertions but need to figure out how to document these requirements.)Would resolve #4 and #5.