Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simple implementation for translating the generated subtitles using the DeepL API #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Akazfu
Copy link

@Akazfu Akazfu commented Feb 9, 2024

A simple implementation for translating the generated subtitles using the DeepL API into any specified language, following the source code conventions.

Copy link

what-the-diff bot commented Feb 9, 2024

PR Summary

  • Expanded README.md with Translation Instructions
    We've upgraded the README.md file to include a section on how to translate subtitles using DeepL API. This section also details setting up the 'DEEPL_AUTH_KEY' for authentication and usage of --translate_subtitles and --translation_language flags.

  • Updated Command-line Interface (CLI)
    The cli.py file now includes the deepl import and supports the --translate_subtitles and --translation_language arguments. These updates make it easier to interact with our program from the command line and manage subtitle translations.

  • Enhanced get_subtitles Function
    We've bolstered the get_subtitles feature to handle translations via DeepL API when the --translate_subtitles flag is active. The function now recovers the DeepL authentication key from the environment variables and employs it in the translate_text_with_deepl function.

  • Added translate_text_with_deepl Function
    A new feature, translate_text_with_deepl, has been added to enable textual translations using the DeepL API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant