Skip to content

Commit

Permalink
Switch to zip assembly
Browse files Browse the repository at this point in the history
  • Loading branch information
m-dzianishchyts committed Oct 3, 2024
1 parent b772f42 commit 44ff605
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/prepare-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Collect the release distributions
run: |
mkdir -p release/
cp jjava/target/jjava-${{ github.ref_name }}-kernelspec.tar.gz release/
cp jjava/target/jjava-${{ github.ref_name }}-kernelspec.zip release/
cp -r dist/* release/
- name: Store the release distributions
Expand Down
2 changes: 1 addition & 1 deletion DEV-GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Alternatively, you could just build it and install as with any release version:

```bash
mvn clean package
mkdir -p "${TARGET_PATH}" && tar -xzf "${BUILD_DIR}".tar.gz -C "${TARGET_PATH}"
unzip -u "${BUILD_DIR}".zip -d "${TARGET_PATH}"
jupyter kernelspec install "${TARGET_PATH}" --name=java --user
```

Expand Down
5 changes: 2 additions & 3 deletions install-snapshot.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@ BUILD_DIR="jjava/target/jjava-${BUILD_VERSION}-kernelspec"
KERNEL_DIR="$(pwd)/${BUILD_DIR}"

mvn clean package || exit 1
mkdir -p "${BUILD_DIR}" || exit 2
tar -xzf "${BUILD_DIR}".tar.gz -C "${BUILD_DIR}" || exit 3
jupyter kernelspec install "${KERNEL_DIR}" --name=java --user || exit 4
unzip -u "${BUILD_DIR}".zip -d "${BUILD_DIR}" || exit 2
jupyter kernelspec install "${KERNEL_DIR}" --name=java --user || exit 3
2 changes: 1 addition & 1 deletion jjava/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
<descriptor>assembly/kernelspec.xml</descriptor>
</descriptors>
<formats>
<format>tar.gz</format>
<format>zip</format>
</formats>
</configuration>
</execution>
Expand Down

0 comments on commit 44ff605

Please sign in to comment.