Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind by default to localhost and added security warning #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

antipatico
Copy link
Contributor

@antipatico antipatico commented Sep 29, 2022

The suggested bind method, which would not specify the bind address, would lead to binding on 0.0.0.0, potentially allowing an attacker connected to the same LAN of the hypervisor running this docker container to access this service.

As described in the patch, binding to localhost won't completely solve the problem, but it can definitely help against low skill attackers.

Security Warning

It is highly suggested to not change the default binding address (127.0.0.1), to prevent computers connected in the same Local Area Network of your hypervisor access to virt-manger.

It is also worth mentioning that a very motivated attacker having access to your LAN, could still be able to access even when binded on 127.0.0.1.

The suggested bind method, which would not specify the bind address, would lead to binding on 0.0.0.0, potentially allowing an attacker connected to the same LAN of the hypervisor running this docker container to access this service.

Binding to localhost won't completely solve the problem, but it can definitely help against low skill attackers.
@m-bers
Copy link
Owner

m-bers commented Nov 10, 2022

I primarily use this container on a headless server and I'd guess I'm not alone in wanting the container to be accessible to the LAN. Simply binding to localhost is not the approach I want to take but I do take your point that this is a security risk. I propose splitting off NGINX into a separate container and setting up basic auth (or another form of auth). What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants