Skip to content

Commit

Permalink
Update backed and CLI to use v2.0 (#15)
Browse files Browse the repository at this point in the history
* remove pre-release; add v20 (v2.0)

* pull from v2.0
  • Loading branch information
aaraney authored Nov 3, 2023
1 parent 8c086be commit 038b029
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions cli/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Usage:
Examples:
hfsubset -l divides,nexus \
-o ./divides_nexus.gpkg \
-r "pre-release" \
-r "v20" \
-t hl_uri \
"Gages-06752260"
Expand Down Expand Up @@ -106,7 +106,8 @@ func (opts *SubsetRequest) MarshalJSON() ([]byte, error) {

jsonmap["layers"] = opts.Layers()
jsonmap[key] = opts.IDs()
jsonmap["version"] = "pre-release"
// TODO: use opts.version
jsonmap["version"] = "v20" // v20 is v2.0
return json.Marshal(jsonmap)
}

Expand Down
2 changes: 1 addition & 1 deletion runtime.R
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ subset <- function(
nldi = NULL,
loc = NULL,
layers = c("divides", "nexus", "flowpaths", "network", "hydrolocations"),
version = c("pre-release", "v1.0", "v1.1", "v1.2")
version = c("v1.0", "v1.1", "v1.2", "v20")
) {
version <- match.arg(version)
s3_uri <- paste0("s3://lynker-spatial/", version, "/")
Expand Down

2 comments on commit 038b029

@mikejohnson51
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this would pull from the vendored R code right? Might be an easier way to keep them in sync? Is that possible @aaraney?

@aaraney
Copy link
Contributor Author

@aaraney aaraney commented on 038b029 Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this would pull from the vendored R code right? Might be an easier way to keep them in sync? Is that possible @aaraney?

@mikejohnson51, yes and yes. @program-- was suggesting we use git submodules and a github action to keep it up to date. That conversation is over here #21 (comment).

Please sign in to comment.