Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for recording audio and screensharing streams #1265

Closed
wants to merge 13 commits into from
Closed

Fix for recording audio and screensharing streams #1265

wants to merge 13 commits into from

Conversation

zafergurel
Copy link
Contributor

Description
ExternalOutput does not record audio-only or video-only (screensharing) streams.

The changes introduced in this commit lets ExternalOutput to be aware that the stream is an audio-only or video-only stream.

Also please look at #1254 .
The comments about this PR made this PR possible.

Issues #1203 and #1185 are related and can be fixed with this PR.

[x] It needs and includes Unit Tests

Changes in Client or Server public APIs
ExternalOutput in erizoAPI has been changed.
A new method named setHasAudioAndVideo has been added to ExternalOutput (ExternalOutput.h and ExternalOutput.cc).

@zafergurel
Copy link
Contributor Author

I've compiled and tested those changes in this PR.
It works but I don't understand why the tests fail.
Anyone that wants to proceed to solve this recording issue can get an idea how it's done.
I won't try more to get this PR passing the tests.

@nvazquezg
Copy link

@zafergurel I've made a PR in your fork that should pass the tests: https://github.com/advancity/licode/pull/2

@zafergurel
Copy link
Contributor Author

@nvazquezg Thank you. 👍

@nvazquezg
Copy link

@zafergurel I found no problems with the recordings of video-and-audio streams and audio-only streams, there is also no delay in the start of the recording 👍

But the screen (video-only) is not working in my tests:

The logs show:
media.ExternalOutput - hasVideo_: 1 hasAudio_: 1 video_codec_: 141 audio_codec_: 0

And this makes true this condition, that invalidates the output:
https://github.com/advancity/licode/blob/082fc5eed4ffd227cc39402693e28ff9c7bb8d8a/erizo/src/erizo/media/ExternalOutput.cpp#L389-L391

Any ideas to fix this situation?

@nvazquezg
Copy link

@zafergurel This problem was in my client side, I was creating the screenshare stream with audio: true. Setting audio:false in the client side fixed the problem.
I did not find any other problems, so this LGTM. 👍

@zafergurel
Copy link
Contributor Author

@nvazquezg Very good. 👍

Setting audio:false in the client side fixed the problem

@zafergurel
Copy link
Contributor Author

@nvazquezg I still have missing parts in the recording file. I use the docker container.
Audio is being recorded after some time passes so that the beginning of the audio is missing.
Also, the end of recording is missing. I suspect that the last video frames are not recorded properly when I close my web cam.
I use windows 8.1 and chrome.
Have you faced those problems?
With such improper recording, I'm not able to use licode.

@nvazquezg
Copy link

nvazquezg commented Jul 23, 2018

@zafergurel With your PR, the recordings don't miss any audio or video at the beginning. The last ~5 seconds of the recording are missing, though, but it is close enough for my use case ATM. I'm compiling directly from source, not using docker yet.
I guess it may be related to the output of the last packets remaining when stopping the recording...

Have you tested this PR? #1218
And H264? #1124

@zafergurel
Copy link
Contributor Author

@nvazquezg I have not tested those PRs yet. I'll check them out as soon as I find time.
Thanks for sharing. 👍

@nvazquezg
Copy link

@lodoyun @jcague Could you please review and consider merging this PR? It solves #1185 and #1203.

@ababutski
Copy link

Also waiting for this PR.

@footniko
Copy link

footniko commented Oct 9, 2018

Any updates on this?

@footniko
Copy link

footniko commented Oct 26, 2018

This fix still doesn't allow recording screen sharing with audio enabled :(

@peererror
Copy link

any update on this pull

@Arri98 Arri98 mentioned this pull request Mar 11, 2022
@zafergurel
Copy link
Contributor Author

This is fixed by #1808. So, it's time to close it.

@zafergurel zafergurel closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants