Bump version to 0.16.x, respect new tag names #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps with making the code more debuggable/maintainable
With 0.16.x, we started to release the lychee CLI binary separately from the lychee library. As a consequence, the crates get prefixed differently on GitHub releases: - CLI binary: `lychee-v0.16.0` - Library: `lychee-lib-v0.16.0` We need to account for that when downloading the binary, as shown in this commit.
mre
force-pushed
the
refactor-action-steps-bump-version
branch
from
88ffbfe to
9bdee7d
Compare
sebastiaanspeck
approved these changes
Oct 7, 2024
|
Fix #250 OR rename lycheeVersion from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 0.16.x, we started to release the lychee CLI binary separately from the lychee library. As a consequence, the crates get prefixed differently on GitHub releases:
lychee-v0.16.0lychee-lib-v0.16.0We need to account for that when downloading the binary, as shown in this commit.
Should be merged after #248, which refactors the pipeline a bit to make discovering those issues easier in the future.
@sebastiaanspeck fyi