Skip to content

Commit

Permalink
Obsolete (#1121)
Browse files Browse the repository at this point in the history
* Drop application desktop file name suffix

The documentation states that the file name, without the full path or the
trailing ".desktop" extension.
Avoids a runtime warning.

* Drop QVariant obsolete methods
  • Loading branch information
luis-pereira authored May 8, 2024
1 parent ff241f9 commit 207c7af
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ int main(int argc, char *argv[])
QApplication::setApplicationName(QStringLiteral("qterminal"));
QApplication::setApplicationVersion(QStringLiteral(QTERMINAL_VERSION));
QApplication::setOrganizationDomain(QStringLiteral("qterminal.org"));
QApplication::setDesktopFileName(QLatin1String("qterminal.desktop"));
QApplication::setDesktopFileName(QLatin1String("qterminal"));
// Warning: do not change settings format. It can screw bookmarks later.
QSettings::setDefaultFormat(QSettings::IniFormat);

Expand Down
2 changes: 1 addition & 1 deletion src/tabwidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ void TabWidget::removeFinished()
{
QObject* term = sender();
QVariant prop = term->property(TAB_INDEX_PROPERTY);
if(prop.isValid() && prop.canConvert(QVariant::Int))
if(prop.isValid() && prop.canConvert<int>())
{
int index = prop.toInt();
removeTab(index);
Expand Down

0 comments on commit 207c7af

Please sign in to comment.