[Draft] Add plugin framework conflics_with and at_least_one_of to instance #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #180 |
breml
reviewed
Dec 9, 2024
| @@ -116,6 +117,21 @@ func (r InstanceResource) Schema(_ context.Context, _ resource.SchemaRequest, re | |||
| PlanModifiers: []planmodifier.String{ | |||
| stringplanmodifier.RequiresReplace(), | |||
| }, | |||
| Validators: []validator.String{ | |||
There was a problem hiding this comment.
Please check the formatting with gofmt. In Go indentation is done with tab (and not spaces).
| path.MatchRoot("source_file"), | ||
| }... | ||
| ), | ||
| stringvalidator.AtLeastOneOf( |
There was a problem hiding this comment.
The current implementation enforces atMostOneOf, which is not the same as AtLeastOneOf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added declarative validator built-in the provider framework instead of imperatively checking in Validate function.