Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new incus_network_peer resource #157

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

Unitiser
Copy link
Contributor

Hello,

This is the PR for #123.

@maveonair maveonair requested a review from stgraber November 11, 2024 08:08

resource "incus_network_peer" "lan0_lan1"{
name = "lab0-lan1"
network = "lan0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do:

network = incus_network.lan0.name
target_network: = incus_network.lan1.name

then you can remove the depends_on

}

resource "incus_network_peer" "lan1_lan0"{
name = "lab1-lan0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do:

network = incus_network.lan0.name
target_network: = incus_network.lan1.name

then you can remove the depends_on

target_project = "projectB"
target_network = "lan1"

depends_on = ["incus_network.projectA_lan0", "incus_network.projectB_lan1"]
Copy link
Member

@maveonair maveonair Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do:

network = incus_network.projectA_lan0.name
target_network: = incus_network.projectB_lan1.name

then you can remove the depends_on

target_project = "projectA"
target_network = "lan0"

depends_on = ["incus_network.projectA_lan0", "incus_network.projectB_lan1"]
Copy link
Member

@maveonair maveonair Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do:

network = incus_network.projectA_lan0.name
target_network: = incus_network.projectB_lan1.name

then you can remove the depends_on

@stgraber stgraber added the Incomplete Waiting on more information from reporter label Nov 25, 2024
@stgraber
Copy link
Member

stgraber commented Dec 3, 2024

@Unitiser any chance you can update your PR based on the comments above?
Also, we just merged #173 which comes with a few disabled tests that are waiting on this PR, it'd be great to add a commit which enables them.

@Unitiser
Copy link
Contributor Author

Hello, I apologize for the delay.

I made the fix you requested, hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incomplete Waiting on more information from reporter
Development

Successfully merging this pull request may close these issues.

3 participants