-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new incus_network_peer resource #157
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Cusson <[email protected]>
Signed-off-by: Nicolas Cusson <[email protected]>
Signed-off-by: Nicolas Cusson <[email protected]>
|
||
resource "incus_network_peer" "lan0_lan1"{ | ||
name = "lab0-lan1" | ||
network = "lan0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do:
network = incus_network.lan0.name
target_network: = incus_network.lan1.name
then you can remove the depends_on
} | ||
|
||
resource "incus_network_peer" "lan1_lan0"{ | ||
name = "lab1-lan0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do:
network = incus_network.lan0.name
target_network: = incus_network.lan1.name
then you can remove the depends_on
target_project = "projectB" | ||
target_network = "lan1" | ||
|
||
depends_on = ["incus_network.projectA_lan0", "incus_network.projectB_lan1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do:
network = incus_network.projectA_lan0.name
target_network: = incus_network.projectB_lan1.name
then you can remove the depends_on
target_project = "projectA" | ||
target_network = "lan0" | ||
|
||
depends_on = ["incus_network.projectA_lan0", "incus_network.projectB_lan1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do:
network = incus_network.projectA_lan0.name
target_network: = incus_network.projectB_lan1.name
then you can remove the depends_on
Signed-off-by: Nicolas Cusson <[email protected]>
Signed-off-by: Nicolas Cusson <[email protected]>
Hello, I apologize for the delay. I made the fix you requested, hope this helps! |
Hello,
This is the PR for #123.