Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/lxd-to-incus: Uncompress snapshot files in target database #69

Merged
merged 2 commits into from
Sep 7, 2023
Merged

cmd/lxd-to-incus: Uncompress snapshot files in target database #69

merged 2 commits into from
Sep 7, 2023

Conversation

freeekanayaka
Copy link
Contributor

Fixes #66

@freeekanayaka
cmd/lxd-to-incus: Run gofmt
32c270b 
Signed-off-by: Free Ekanayaka <[email protected]>
@freeekanayaka freeekanayaka force-pushed the lxd-to-incus-uncompress-snapshots branch from 03047ee to 481e1c2 Compare September 7, 2023 12:18
stgraber
stgraber requested changes Sep 7, 2023
View reviewed changes
cmd/lxd-to-incus/db.go Outdated Show resolved Hide resolved
cmd/lxd-to-incus/db.go Outdated Show resolved Hide resolved
cmd/lxd-to-incus/db.go Outdated Show resolved Hide resolved
cmd/lxd-to-incus/main.go Show resolved Hide resolved
@stgraber
Copy link
Member

stgraber commented Sep 7, 2023

@freeekanayaka so this will uncompress the database on migration, but I guess we need another change to have Incus not set it up to be compressed in the first place, right?

Otherwise as soon as we start Incus, it will just go back to being compressed again, no?

@freeekanayaka
Copy link
Contributor Author

@freeekanayaka so this will uncompress the database on migration, but I guess we need another change to have Incus not set it up to be compressed in the first place, right?

Otherwise as soon as we start Incus, it will just go back to being compressed again, no?

Not really, as soon as this lands I'd disable/remove compressing entirely from cowsql.

@freeekanayaka freeekanayaka force-pushed the lxd-to-incus-uncompress-snapshots branch from 481e1c2 to 1c7a455 Compare September 7, 2023 14:23
@freeekanayaka freeekanayaka merged commit ae7db9c into lxc:main Sep 7, 2023
@freeekanayaka freeekanayaka deleted the lxd-to-incus-uncompress-snapshots branch September 7, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable raft snapshot compression
2 participants
@freeekanayaka @stgraber