Add --description flag to create type CLI commands
#1498
Conversation
|
@stgraber opening as a draft because I still want to add some test cases for the commands. Is the I did some manual tests to validate most of the changes, but I was a bit limited by my local setup to test the |
luissimas
changed the title
--description flag to create type CLI commands
Yeah, you can have a few of the commands in there start passing |
Adds a --description flag to various commands that create resources. Signed-off-by: Luís Simas <[email protected]>
Adds a description field on the request schema of instance and volume snapshots for POST and GET routes. Signed-off-by: Luís Simas <[email protected]>
Adds a --description flag to the create subcommand of the snapshot and storage volume snapshot commands. Also adds the ability to display the description field in query commands. Signed-off-by: Luís Simas <[email protected]>
Adds support for specifying a description on both instance and volume snapshots. In the case of snapshots created by the user, the description can be provided via the HTTP API. In the case of snapshots created automatically by Incus, a default description value is used. Signed-off-by: Luís Simas <[email protected]>
Signed-off-by: Luís Simas <[email protected]>
luissimas
force-pushed
the
description-flag
branch
from
4dc1e7d to
47db142
Compare
|
Looks good overall. I'll have to take a closer look at the snapshot description stuff as I now have a nagging feeling that we have those fields read-only as we want the snapshot to capture and restore the instance or volume's own description. If that's indeed the case, we'll then want to just remove the ability to set a description on snapshots at creation time which will also make this PR a bit simpler. |
Adds a
--descriptionCLI flag to the following commands:config trust add-certificatecluster group createcreateimage alias createlaunchnetwork createnetwork acl createnetwork acl rule addnetwork forward createnetwork forward port addnetwork load-balancer createnetwork load-balancer backend addnetwork load-balancer port addnetwork peer createnetwork zone createnetwork zone record addprofile createproject createstorage createstorage bucket createstorage bucket key createstorage volume createstorage volume snapshot createsnapshot createThe flag allow users to set a description on the resources when they create them, instead of having to update the description after the creation.
For the
snapshot createandstorage volume snapshot createcommands, some changes were made to the API and theincusddaemon, since thedescriptionfield was not supported on the server side. Additionally, the new description field is shown in the output ofincus storage volume snapshot list,incus snapshot listandincus info.Closes #1485