incusd/instance/qemu: Fix random ordering in ETag

Signed-off-by: Stéphane Graber <[email protected]>
Sponsored-by: https://webdock.io

internal/server/instance/drivers/driver_qemu.go

@@ -7865,9 +7865,7 @@ func (d *qemu) Render(options ...func(response any) error) (any, any, error) {
 	}
 
 	if d.IsSnapshot() {
-		// Prepare the ETag
-		etag := []any{d.expiryDate}
-
+		// Prepare the response.
 		snapState := api.InstanceSnapshot{
 			CreatedAt:       d.creationDate,
 			ExpandedConfig:  d.expandedConfig,
@@ -7892,13 +7890,14 @@ func (d *qemu) Render(options ...func(response any) error) (any, any, error) {
 			}
 		}
 
+		// Prepare the ETag.
+		etag := []any{d.expiryDate}
+
 		return &snapState, etag, nil
 	}
 
-	// Prepare the ETag
-	etag := []any{d.architecture, d.localConfig, d.localDevices, d.ephemeral, d.profiles}
+	// Prepare the response.
 	statusCode := d.statusCode()
-
 	instState := api.Instance{
 		ExpandedConfig:  d.expandedConfig,
 		ExpandedDevices: d.expandedDevices.CloneNative(),
@@ -7927,6 +7926,20 @@ func (d *qemu) Render(options ...func(response any) error) (any, any, error) {
 		}
 	}
 
+	// Prepare the ETag.
+	etag := []any{d.architecture, d.ephemeral, d.profiles, d.localDevices.Sorted()}
+
+	configKeys := make([]string, 0, len(d.localConfig))
+	for k := range d.localConfig {
+		configKeys = append(configKeys, k)
+	}
+
+	sort.Strings(configKeys)
+
+	for _, k := range configKeys {
+		etag = append(etag, fmt.Sprintf("%s=%s", k, d.localConfig[k]))
+	}
+
 	return &instState, etag, nil
 }