Skip to content

Commit

Permalink
Package.swift: mark entire testTarget region as dev for rocket
Browse files Browse the repository at this point in the history
As @lukewakeford pointed out in Moya@3206a0f#r81024749
our rocket integration for hiding dev dependencies
(https://github.com/shibapm/Rocket#hide-dev-dependencies) was
producing a malformed Package.swift for releases. this should fix the
issue by instructing Rocket to comment out the entire testTarget,
instead of just the `name:` line
  • Loading branch information
AndrewSB committed Aug 12, 2022
1 parent 28457ca commit 8ae8a0d
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 11 deletions.
4 changes: 4 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Next

### Fixed

- Un-break Package.swift parsing when releasing through Rocket. [#2275](https://github.com/Moya/Moya/pull/2274) by [@AndrewSB](https://github.com/AndrewSB)

# [15.0.1] - 2022-08-11

### Fixed
Expand Down
22 changes: 11 additions & 11 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,18 @@ let package = Package(
.product(name: "RxSwift", package: "RxSwift")
]
),
.testTarget(
.testTarget( // dev
name: "MoyaTests", // dev
dependencies: [
"Moya",
"CombineMoya",
"ReactiveMoya",
"RxMoya",
.product(name: "Quick", package: "Quick"),
.product(name: "Nimble", package: "Nimble"),
.product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs")
]
)
dependencies: [ // dev
"Moya", // dev
"CombineMoya", // dev
"ReactiveMoya", // dev
"RxMoya", // dev
.product(name: "Quick", package: "Quick"), // dev
.product(name: "Nimble", package: "Nimble"), // dev
.product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs") // dev
] // dev
) // dev
]
)

Expand Down

0 comments on commit 8ae8a0d

Please sign in to comment.