Skip to content

Commit

Permalink
Don't assert if inserting a rowid with a matching timepoint does not …
Browse files Browse the repository at this point in the history
…create a conflict (rerun-io#1832)
  • Loading branch information
jleibs authored Apr 12, 2023
1 parent d2d83d7 commit c181adf
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions crates/re_arrow_store/src/store_write.rs
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,10 @@ impl MetadataRegistry<TimePoint> {
let entry = entry.get_mut();
for (timeline, time) in timepoint {
if let Some(old_time) = entry.insert(timeline, time) {
re_log::error!(%row_id, ?timeline, old_time = ?old_time, new_time = ?time, "detected re-used `RowId/Timeline` pair, this is illegal and will lead to undefined behavior in the datastore");
debug_assert!(false, "detected re-used `RowId/Timeline`");
if old_time != time {
re_log::error!(%row_id, ?timeline, old_time = ?old_time, new_time = ?time, "detected re-used `RowId/Timeline` pair, this is illegal and will lead to undefined behavior in the datastore");
debug_assert!(false, "detected re-used `RowId/Timeline`");
}
}
}
}
Expand Down

0 comments on commit c181adf

Please sign in to comment.