Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appveyor to build/release Windows binaries #201

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

squeek502
Copy link
Member

Only does the deploy phase for tagged commits

Contributes towards #200


Tested and confirmed to work. Example:

Note that the auth_token used in this PR is one I generated, and I think it'll work for the luvit/luvi repo, but maybe it makes more sense for someone else to generate it? See https://www.appveyor.com/docs/deployment/github/#provider-settings for more info about auth_token

Only does the deploy phase for tagged commits

Contributes towards luvit#200
@squeek502
Copy link
Member Author

Can *.lib be ignored, what problems do they solve?

I'm not exactly sure. I included them because they were included in previous Luvi releases: https://github.com/luvit/luvi/releases/tag/v2.7.6

@squeek502 squeek502 mentioned this pull request Mar 27, 2019
10 tasks
@zhaozg
Copy link
Member

zhaozg commented Mar 27, 2019

good job. I vote to remove *.lib for file numbers and size,if need we can add it lately

@squeek502
Copy link
Member Author

squeek502 commented Mar 27, 2019

Looks like the .lib files are used for linking Windows Lua modules that work with Luvi:

@rphillips would probably know more.

@zhaozg
Copy link
Member

zhaozg commented Mar 27, 2019

ok #97 (comment) say clearly.

@zhaozg zhaozg requested review from zhaozg and removed request for zhaozg March 27, 2019 08:26
@rphillips rphillips merged commit 63b866b into luvit:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants