This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Uncompressed Encodings for Affine Points #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Rust toolchain to version 1.59.0 to satisfy the requirement of constant_time_eq v0.2.5, - Implement UncompressedEncoding for affine representations, - Add `paste` dependency at version 1.0.12 in order to give a specific struct for that representation for each of Pallas, Vesta.
huitseeker
reviewed
Jun 7, 2023
There was a problem hiding this comment.
Concept ACK, but I think it will be tremendously easier to maintain this once upstream merges, if we use the base PR as much as possible.
In this case, the diff is trivial, but for the leftover serde_bytes dependency. You may want to reset to the branch at https://github.com/huitseeker/pasta_curves/tree/uncompressed
|
moving out of the fork |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR and branch is a mirror of zcash#73 and is intended to be maintained for development/internal use.