forked from jenkins-x-buildpacks/jenkins-x-kubernetes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1 from luminaraio/fix-build-agent-container-name
INFRA-0033 | Yohane | fix the name of build agent's the container
- Loading branch information
Showing
2 changed files
with
55 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# PR-0001 | ||
|
||
[NOTE] | ||
==== | ||
This project has a dependency on | ||
https://github.com/jenkins-x-buildpacks/jenkins-x-kubernetes[jenkins-x-kubernetes buildpacks] | ||
It basically an extension of it, it was forked from it | ||
==== | ||
|
||
## Scope of Feature | ||
This PR is basically a fix added to the initial work that had been done on this project. The fix consists in changing the name of the container of the build agent in the gradle5 buildpack. This name is specified in the *pipeline.yaml* file. | ||
|
||
## How to validate Feature | ||
To effectively validated that the PR fixes what it is suppose to fix: | ||
|
||
. Create or import a sample project with the *jx* command-line program. | ||
+ | ||
Execute: | ||
+ | ||
``` | ||
jx create quickstart --pack gradle5 -g luminaraio | ||
``` | ||
+ | ||
and follow the instruction in the _quickstart import wizard_ and when promoted | ||
(_"select the quickstart you wish to create"_) choose *chose a gradle quickstart project* | ||
|
||
+ | ||
*OR* | ||
|
||
+ | ||
cd in the an existing gradle project folder and execute: | ||
|
||
+ | ||
``` | ||
jx import --pack gradle5 -g luminaraio | ||
``` | ||
|
||
. Validate that the initial pipeline in *Jenkins X* was launched and wait for it ot complete then validate that a _successful promotion/deployment to the **staging**_ happened. To open **Jenkins**, you can execute: | ||
|
||
+ | ||
``` | ||
jx console | ||
``` | ||
|
||
+ | ||
Execute: | ||
+ | ||
``` | ||
jx get application (1) | ||
``` | ||
* You Should be able to obtain the url of the new created or imported application | ||
* You should be able to send a request to the staging URL and receive a valid response |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ extends: | |
file: ../gradle/pipeline.yaml | ||
agent: | ||
label: jenkins-gradle5 | ||
container: gradle | ||
container: gradle5 |