add django, and modernize flask with content

lumigo-io · Sep 11, 2023 · ff97dc4 · ff97dc4
1 parent 0cd1db8
commit ff97dc4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/lumigo_opentelemetry/instrumentations/django/__init__.py b/src/lumigo_opentelemetry/instrumentations/django/__init__.py
@@ -19,15 +19,17 @@ def install_instrumentation(self) -> None:
         from opentelemetry.instrumentation.django import DjangoInstrumentor
         from django.http import HttpRequest, HttpResponse
 
-        def request_hook(span: Span, request: HttpRequest):
+        def request_hook(span: Span, request: HttpRequest) -> None:
             with lumigo_safe_execute("django request_hook"):
                 span.set_attribute(
                     "http.request.headers",
                     dump_with_context("requestHeaders", request.headers),
                 )
                 add_body_attribute(span, request.body, "http.request.body")
 
-        def response_hook(span: Span, request: HttpRequest, response: HttpResponse):
+        def response_hook(
+            span: Span, request: HttpRequest, response: HttpResponse
+        ) -> None:
             with lumigo_safe_execute("django response_hook"):
                 span.set_attribute(
                     "http.response.headers",

diff --git a/src/lumigo_opentelemetry/instrumentations/flask/__init__.py b/src/lumigo_opentelemetry/instrumentations/flask/__init__.py
@@ -17,14 +17,16 @@ def check_if_applicable(self) -> None:
     def install_instrumentation(self) -> None:
         from opentelemetry.instrumentation.flask import FlaskInstrumentor
 
-        def request_hook(span: Span, flask_request_environ: Dict[str, Any]):
+        def request_hook(span: Span, flask_request_environ: Dict[str, Any]) -> None:
             with lumigo_safe_execute("flask_request_hook"):
                 span.set_attribute(
                     "http.request.headers",
                     dump_with_context("requestHeaders", flask_request_environ),
                 )
 
-        def response_hook(span: Span, status, response_headers):
+        def response_hook(
+            span: Span, status: int, response_headers: Dict[str, Any]
+        ) -> None:
             with lumigo_safe_execute("flask_response_hook"):
                 span.set_attribute(
                     "http.response.headers",