Skip to content

Commit

Permalink
fixing test_logging
Browse files Browse the repository at this point in the history
  • Loading branch information
Eugene Orlovsky committed Aug 29, 2024
1 parent 212b0e0 commit 13e6efe
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/test/integration/logging/tests/test_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,9 @@ def test_logging_enabled(self):
)

for log in logs:
# "resource" is currently not a proper dictionary, but a string from a repr(...) call over the resource attributes.
# Pending a fix in https://github.com/open-telemetry/opentelemetry-python/pull/3346
self.assertIn("'service.name': 'logging-app'", log["resource"])
# self.assertEqual(log["resource"]["service.name"], "logging-app")
self.assertEqual(
log["resource"]["attributes"]["service.name"], "logging-app"
)

self.assertIn("attributes", logs[0])

Expand Down

0 comments on commit 13e6efe

Please sign in to comment.