Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add schemas to display addresses for LSP1 Type Ids #117

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat: add schemas to display addresses for LSP1 Type Ids #117

merged 1 commit into from
Oct 17, 2024

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Aug 16, 2024 •
edited
Loading

image

JeneaVranceanu
JeneaVranceanu reviewed Aug 17, 2024
View reviewed changes
components/ValueTypeDecoder/ValueTypeDecoder.tsx
@@ -66,6 +66,18 @@ const ValueTypeDecoder: React.FC<Props> = ({
}, [address, web3, erc725JSONSchema, value]);

try {
if (decodedDataOneKey[0].name.startsWith('LSP1UniversalReceiverDelegate')) {
const badgeContent = decodedDataOneKey[0].value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

badgeContent is the asset's address?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's null maybe we should hide AddressButtons?

@CJ42 CJ42 merged commit 9381b6d into main Oct 17, 2024
1 check passed
@CJ42 CJ42 deleted the lsp1-type-ids branch October 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CJ42 @JeneaVranceanu