Skip to content

Commit

Permalink
Remove mostly unused util.py
Browse files Browse the repository at this point in the history
The util.py module provides a mix of minimal functions related to local files
and directories. These functions are mostly unused, exceptions are
(according to sourcegraph.com):

- persist_temp_file in python-tuf (cc @jku)
- get_file_hashes in scai-demos (cc @marcelamelara, @adityasaky)
- get_file_details, load_json_file in taf (cc @renatav, @adityasaky)

It seems feasible to reimplement the desired functionality downstream.

The benefits of removing util.py are:

- minimizes the API surface
- removes one dependent of the about to be removed schema.py (secure-systems-lab#183)
- makes unittest_toolbox obsolete

Ping python-tuf (will need to port one function) and scai-demo

Signed-off-by: Lukas Puehringer <[email protected]>
  • Loading branch information
lukpueh committed Apr 10, 2024
1 parent 7852d25 commit a32a996
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 1,008 deletions.
1 change: 0 additions & 1 deletion mypy.ini
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[mypy]
warn_unused_configs = True
files =
securesystemslib/util.py,
securesystemslib/signer/*.py,
securesystemslib/storage.py,
securesystemslib/gpg/constants.py
Expand Down
136 changes: 0 additions & 136 deletions securesystemslib/unittest_toolbox.py

This file was deleted.

Loading

0 comments on commit a32a996

Please sign in to comment.