Deferred viewports #306
Merged
Deferred viewports #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukexor
force-pushed
the
deferred_viewports
branch
from
3bd532e to
4b14a1a
Compare
|
Well unfortunately, it turns out that the For now, desktop can be deferred until winit is upgraded. |
lukexor
added a commit
that referenced
this pull request
Jun 25, 2024
Closed
Closed
This was referenced Nov 11, 2024
Closed
Closed
Closed
This was referenced Nov 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all uses of immediate viewports and support for them, which removes the one use of unsafe. Since tetanes is not intended to be a general-purpose library, immediate viewports are not required and, as they are less performant, not desired.
Smaller windows will be in-frame, and larger, more complex windows, will be deferred with their own repaints.
Closes #296