Bug fixed: Setting an empty string or "null" to defaultElement may ca…

…use a JavaScript error (#51)
luke-chang · Mar 2, 2022 · 4dd23c6 · 4dd23c6
1 parent 1a59d0b
commit 4dd23c6
Showing 1 changed file with 15 additions and 11 deletions.
diff --git a/spatial_navigation.js b/spatial_navigation.js
@@ -449,17 +449,21 @@
   }
 
   function parseSelector(selector) {
-    var result;
-    if ($) {
-      result = $(selector).get();
-    } else if (typeof selector === 'string') {
-      result = [].slice.call(document.querySelectorAll(selector));
-    } else if (typeof selector === 'object' && selector.length) {
-      result = [].slice.call(selector);
-    } else if (typeof selector === 'object' && selector.nodeType === 1) {
-      result = [selector];
-    } else {
-      result = [];
+    var result = [];
+    try {
+      if (selector) {
+        if ($) {
+          result = $(selector).get();
+        } else if (typeof selector === 'string') {
+          result = [].slice.call(document.querySelectorAll(selector));
+        } else if (typeof selector === 'object' && selector.length) {
+          result = [].slice.call(selector);
+        } else if (typeof selector === 'object' && selector.nodeType === 1) {
+          result = [selector];
+        }
+      }
+    } catch (err) {
+      console.error(err);
     }
     return result;
   }