simplify and refactor tests #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @pytest.fixture | ||
| def mock_fake_credentials(): | ||
| return { | ||
| 'jira_base_url': 'https://your-mock-jira-server-url', |
There was a problem hiding this comment.
Być może jest sens użyć tego fixture również w test_load_settings_file_exists
| } | ||
|
|
||
|
|
||
| def test_jira_authentication_success(mock_fake_user, mock_fake_credentials): | ||
|
|
There was a problem hiding this comment.
Można ujednolicić formatowanie, aby po deklaracji funkcji była zawsze albo nie było wcale pustej linii
| attachment1 = MockAttachment('?!?/?!', b'content1') | ||
| attachment2 = MockAttachment('file2.txt', b'content2') | ||
| return MockIssue(attachments=[attachment1, attachment2]) | ||
|
|
||
|
|
||
| def test_download_attachments_validate_files_and_contents_goodfiles(tmpdir, mock_jira_issue_good_files): | ||
| def test_download_attachments_validate_files_and_contents_goodfiles(tmpdir, mock_jira_issue_valid_files): |
There was a problem hiding this comment.
valid_files na końcu nazwy funkcji
| with open(attachment_path, 'rb') as file: | ||
| assert file.read() == attachment.content | ||
|
|
||
|
|
||
| def test_download_attachments_validate_files_and_contents_bad_files(tmpdir, mock_jira_issue_bad_files): | ||
| def test_download_attachments_validate_files_and_contents_bad_files(tmpdir, mock_jira_issue_invalid_files): |
There was a problem hiding this comment.
invalid_files na końcu nazwy funkcji
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.