Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.10, 3.11, 3.12 compatibility #4041

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

Add Python 3.10, 3.11, 3.12 compatibility #4041

wants to merge 32 commits into from
+476 −890

Conversation

mhabedank
Copy link
Collaborator

@mhabedank mhabedank commented Nov 17, 2024 •
edited
Loading

This PR tries to solve the dependency problems we have when going forward to modern Python version.

Things currently done:

  • moved from outdated build system and requirements files to hatch and pyproject.toml
  • removed torchtext, rewrote lots of tokenizer code.
  • removed importlib
  • bumped numpy, torch, scikit-learn and several other dependencies.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3607bd2.

♻️ This comment has been updated with latest results.

This was referenced Nov 20, 2024
Open
Closed
@mhabedank mhabedank changed the title Hatch dev mh Add Python 3.10, 3.11, 3.12 compatibility Nov 20, 2024
@C-L-STARK
Copy link

This PR tries to solve the dependency problems we have when going forward to modern Python version.

Things currently done:

  • moved from outdated build system and requirements files to hatch and pyproject.toml
  • removed torchtext, rewrote lots of tokenizer code.
  • removed importlib
  • bumped numpy, torch, scikit-learn and several other dependencies.

is ludwig on python3.12 supported in this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w4nderlust w4nderlust Awaiting requested review from w4nderlust w4nderlust will be requested when the pull request is marked ready for review w4nderlust is a code owner

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair will be requested when the pull request is marked ready for review tgaddair is a code owner

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao will be requested when the pull request is marked ready for review justinxzhao is a code owner

@arnavgarg1 arnavgarg1 Awaiting requested review from arnavgarg1 arnavgarg1 will be requested when the pull request is marked ready for review arnavgarg1 is a code owner

@geoffreyangus geoffreyangus Awaiting requested review from geoffreyangus geoffreyangus will be requested when the pull request is marked ready for review geoffreyangus is a code owner

@jeffkinnison jeffkinnison Awaiting requested review from jeffkinnison jeffkinnison will be requested when the pull request is marked ready for review jeffkinnison is a code owner

@Infernaught Infernaught Awaiting requested review from Infernaught Infernaught will be requested when the pull request is marked ready for review Infernaught is a code owner

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky alexsherstinsky will be requested when the pull request is marked ready for review alexsherstinsky is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

@ethanreidel ethanreidel

@mhabedank mhabedank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhabedank @C-L-STARK @ethanreidel